Skip to content

PostgreSQL: Support PARTITION OF in CREATE FOREIGN TABLE - #2753

Open
LucaCappelletti94 wants to merge 3 commits into
mainfrom
upstream/foreign-table-partition-of
Open

LucaCappelletti94 wants to merge 3 commits into
mainfrom
upstream/foreign-table-partition-of

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE FOREIGN TABLE part PARTITION OF root FOR VALUES FROM (0) TO (10) SERVER s failed at PARTITION. CreateForeignTable gains partition_of and for_values, mirroring CreateTable, and the column list becomes optional in this form, as in PostgreSQL's grammar.

https://www.postgresql.org/docs/current/sql-createforeigntable.html

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.79%. Comparing base (db724c9) to head (6cd5ba7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2753      +/-   ##
==========================================
+ Coverage   82.72%   82.79%   +0.07%     
==========================================
  Files          42       42              
  Lines       35789    35823      +34     
  Branches    35789    35823      +34     
==========================================
+ Hits        29605    29659      +54     
+ Misses       2668     2652      -16     
+ Partials     3516     3512       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch 2 times, most recently from 8d13c55 to 671f9ff Compare October 28, 2026 20:12
@s5dsn-eqee

Copy link
Copy Markdown
Contributor

While reviewing this I found a bug: #2762.

It existed before this PR, but If you'd like to merge this before #2762 is fixed, it would be better to add red tests that assert the AST (data_type / options) for the untyped column cases

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch 2 times, most recently from 21a50a7 to c3d2e43 Compare October 29, 2026 14:02
@LucaCappelletti94
LucaCappelletti94 changed the base branch from main to upstream/partition-of-untyped-columns October 29, 2026 14:02
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from c3d2e43 to cfe4747 Compare October 29, 2026 18:16
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from cfe4747 to acc0204 Compare October 30, 2026 07:47
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from acc0204 to b3790d0 Compare October 30, 2026 11:15
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from b3790d0 to 8634a16 Compare October 30, 2026 15:05
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch 2 times, most recently from 834fc21 to 1ac1da7 Compare October 30, 2026 18:13
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from 1ac1da7 to fb3f377 Compare October 30, 2026 22:26
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from fb3f377 to da64ac2 Compare October 31, 2026 07:58
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from da64ac2 to bfb700b Compare October 31, 2026 08:59
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from bfb700b to 1ab55ff Compare October 31, 2026 10:20
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from 1ab55ff to 8392197 Compare October 31, 2026 10:46
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from 8392197 to a59b80a Compare October 31, 2026 12:31
Base automatically changed from upstream/partition-of-untyped-columns to main October 31, 2026 13:03
@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-partition-of branch from a59b80a to 6cd5ba7 Compare October 31, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants