Skip to content

PostgreSQL: Support INHERITS in CREATE FOREIGN TABLE - #2752

Merged
LucaCappelletti94 merged 3 commits into
mainfrom
upstream/foreign-table-inherits
Oct 30, 2026
Merged

LucaCappelletti94 merged 3 commits into
mainfrom
upstream/foreign-table-inherits

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

CREATE FOREIGN TABLE child () INHERITS (parent) SERVER s, which pg_dump writes for an inherited foreign table, failed with Expected: SERVER, found: INHERITS. CreateForeignTable gains inherits, mirroring CreateTable.

https://www.postgresql.org/docs/current/sql-createforeigntable.html

@codecov-commenter

codecov-commenter commented Oct 28, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.58%. Comparing base (9f66d76) to head (a86bf34).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2752      +/-   ##
==========================================
+ Coverage   82.54%   82.58%   +0.04%     
==========================================
  Files          42       42              
  Lines       35556    35565       +9     
  Branches    35556    35565       +9     
==========================================
+ Hits        29349    29371      +22     
+ Misses       2672     2660      -12     
+ Partials     3535     3534       -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-inherits branch 5 times, most recently from 15cfdeb to ef213fe Compare October 30, 2026 08:30

@s5dsn-eqee s5dsn-eqee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LucaCappelletti94
LucaCappelletti94 force-pushed the upstream/foreign-table-inherits branch from ef213fe to a86bf34 Compare October 30, 2026 11:16
@LucaCappelletti94

Copy link
Copy Markdown
Contributor Author

Thank you @s5dsn-eqee for the review, I will be merging this now.

cc @alamb

@LucaCappelletti94
LucaCappelletti94 added this pull request to the merge queue Oct 30, 2026
Merged via the queue into main with commit 06c0468 Oct 30, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants