[LucaCappelletti94]

pg_dump writes every partition as a plain CREATE TABLE followed by ALTER TABLE ONLY root ATTACH PARTITION part FOR VALUES FROM (0) TO (10), and that line failed at ATTACH because only the ClickHouse form was parsed.

https://www.postgresql.org/docs/current/sql-altertable.html

[codecov-commenter]

Codecov Report

❌ Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.40%. Comparing base (e15e9ab) to head (11f7fa0).

Files with missing lines	Patch %	Lines
src/ast/spans.rs	0.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2749   +/-   ##
=======================================
  Coverage   82.40%   82.40%           
=======================================
  Files          42       42           
  Lines       35342    35358   +16     
  Branches    35342    35358   +16     
=======================================
+ Hits        29122    29136   +14     
- Misses       2678     2681    +3     
+ Partials     3542     3541    -1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

LGTM!

[LucaCappelletti94]

Thanks @s5dsn-eqee for the review, I will be merging this one.

cc @alamb (btw I am actively not caring much about the spans test coverage because those are a mess in themselves and will require a refactoring, but not anytime soon)