[LucaCappelletti94]

ALTER TABLE t RESET (fillfactor) fails with Expected: ADD, RENAME, PARTITION, SWAP, DROP, REPLICA IDENTITY, SET, or SET TBLPROPERTIES after ALTER TABLE, found: RESET, and a storage parameter named without a value, as in CREATE VIEW v WITH (security_invoker) AS SELECT 1 or ALTER TABLE t SET (autovacuum_enabled), fails with Expected: =. PostgreSQL documents RESET ( storage_parameter [, ... ] ) for ALTER TABLE and reads a storage parameter given without a value as true.

RESET parses into a new AlterTableOperation::ResetOptions holding the parameter names, the shape #2730 uses for ALTER VIEW ... RESET. A key with no = after it parses to the existing SqlOption::Ident behind a new Dialect::supports_sql_option_without_value, which PostgreSQL and Generic enable, so the other dialects still report the missing =. PostgreSQL's grammar also accepts a bare key in CREATE TEXT SEARCH options, so the negative test there now runs on the dialects without the flag.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 90.90909% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.62%. Comparing base (c6cec56) to head (ff54037).

Files with missing lines	Patch %	Lines
src/ast/spans.rs	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2744      +/-   ##
==========================================
+ Coverage   82.60%   82.62%   +0.01%     
==========================================
  Files          42       42              
  Lines       35607    35629      +22     
  Branches    35607    35629      +22     
==========================================
+ Hits        29414    29438      +24     
- Misses       2659     2661       +2     
+ Partials     3534     3530       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sabir-akhadov-localstack]

ALTER TABLE t RESET (toast.autovacuum_enabled) fails with Expected: ), found: .; PostgreSQL 16 accepts it (ALTER TABLE). Vec<ObjectName> via parse_object_name(false) would cover the toast. prefix; SET (toast.autovacuum_enabled = false) has the same limitation through parse_sql_option, which is pre-existing.

[LucaCappelletti94]

Fixed, thank you for pointing this out.

[sabir-akhadov-localstack]

lgtm