Repository navigation
Parser: Share foreign-key reference clause parsing - #2715
Merged
Merged
Conversation
|
No dialect label was applied because the title does not name a SQL dialect. If this change targets one or more dialects, edit the title to |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 82.26% 82.26%
=======================================
Files 42 42
Lines 35303 35304 +1
Branches 35303 35304 +1
=======================================
+ Hits 29041 29044 +3
+ Misses 2698 2697 -1
+ Partials 3564 3563 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Merging also this as it is a cleanup. cc @alamb |
github-merge-queue
Bot
removed this pull request from the merge queue due to a conflict with the base branch
Oct 26, 2026
LucaCappelletti94
force-pushed
the
refactor-reference-clauses
branch
from
October 26, 2026 17:07
353d4d6 to
09f3ffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Column-level
REFERENCESand table-levelFOREIGN KEYconstraints accept the sameMATCH,ON DELETE, andON UPDATEclauses. A shared parser keeps clause ordering and duplicate handling consistent.Addresses the reference-clause duplication tracked in #2698.
Found with cargo-echoes