Skip to content

Spark: Share CACHE TABLE parsing - #2714

Open
LucaCappelletti94 wants to merge 1 commit into
mainfrom
refactor-cache-table
Open

LucaCappelletti94 wants to merge 1 commit into
mainfrom
refactor-cache-table

Conversation

@LucaCappelletti94

Copy link
Copy Markdown
Contributor

The optional cache flag does not change the table, options, or query grammar. Keeping these forms on one parsing path avoids maintaining separate implementations.

Addresses the parse_cache_table duplication tracked in #2698.

Found with https://github.com/LucaCappelletti94/cargo-echoes

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.23%. Comparing base (a9b10d0) to head (0a063ab).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/parser/mod.rs 83.33% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2714      +/-   ##
==========================================
+ Coverage   82.20%   82.23%   +0.03%     
==========================================
  Files          42       42              
  Lines       35314    35283      -31     
  Branches    35314    35283      -31     
==========================================
- Hits        29029    29015      -14     
+ Misses       2716     2703      -13     
+ Partials     3569     3565       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LucaCappelletti94 LucaCappelletti94 changed the title Spark: Share CACHE TABLE parsing [ECHOES] Spark: Share CACHE TABLE parsing Oct 25, 2026
@LucaCappelletti94 LucaCappelletti94 changed the title [ECHOES] Spark: Share CACHE TABLE parsing Spark: Share CACHE TABLE parsing Oct 25, 2026
@LucaCappelletti94 LucaCappelletti94 added the deduplication Removal of duplicated code label Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deduplication Removal of duplicated code Spark

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants