[LucaCappelletti94]

The parser does not recognize DROP RULE, so migration scripts and schema dumps that remove rewrite rules fail to parse. This is the companion of #2433, and the two are independent and can land in either order.

Doc: https://www.postgresql.org/docs/current/sql-droprule.html

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.02%. Comparing base (594bb04) to head (9c43025).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2434      +/-   ##
==========================================
+ Coverage   81.99%   82.02%   +0.02%     
==========================================
  Files          42       42              
  Lines       35049    35082      +33     
  Branches    35049    35082      +33     
==========================================
+ Hits        28740    28776      +36     
+ Misses       2744     2741       -3     
  Partials     3565     3565              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[s5dsn-eqee]

Like it, Span especially

Could you add a few more red tests, e.g.:

#[test]
fn parse_drop_rule_rejects_lists_and_extra_options() {
    for (sql, expected) in [
        ("DROP RULE r1, r2 ON t", "Expected: ON, found: ,"),
        ("DROP RULE s.r ON t", "Expected: ON, found: ."),
        ("DROP RULE 1 ON t", "Expected: identifier, found: 1"),
        ("DROP RULE IF EXISTS", "Expected: identifier, found: EOF"),
        ("DROP RULE IF NOT EXISTS r ON t", "Expected: ON, found: NOT"),
        ("DROP RULE r t", "Expected: ON, found: t"),
        ("DROP RULE r ON (t)", "Expected: identifier, found: ("),
        ("DROP RULE r ON t1, t2", "Expected: end of statement, found: ,"),
        ("DROP RULE r ON t ON t", "Expected: end of statement, found: ON"),
        ("DROP RULE r ON t CASCADE RESTRICT", "Expected: end of statement, found: RESTRICT"),
        ("DROP RULE r ON t RESTRICT CASCADE", "Expected: end of statement, found: CASCADE"),
        ("DROP RULE r ON t PURGE", "Expected: end of statement, found: PURGE"),
    ] {
        let err = all_dialects().parse_sql_statements(sql).unwrap_err().to_string();
        assert!(err.starts_with(&format!("sql parser error: {expected}")), "{sql}: {err}");
    }
}

[s5dsn-eqee]

👍