[fmguerreiro]

Parses CREATE FOREIGN DATA WRAPPER name [HANDLER fn | NO HANDLER] [VALIDATOR fn | NO VALIDATOR] [OPTIONS (...)] (docs).

Split out of this PR at @LucaCappelletti94's request. CREATE FOREIGN TABLE is now #2515.

HANDLER and VALIDATOR are accepted in either order, because the PostgreSQL grammar takes them as an unordered list even though the doc synopsis shows one order.

ALTER FOREIGN DATA WRAPPER and CREATE USER MAPPING are out of scope.

Ported from the pgmold-sqlparser fork.

[LucaCappelletti94]

I suggest to split the PR into two, once for each statement

[fmguerreiro]

split. CREATE FOREIGN TABLE is now #2515.

[codecov-commenter]

Codecov Report

❌ Patch coverage is 90.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.20%. Comparing base (777546c) to head (73e73fe).

Files with missing lines	Patch %	Lines
src/parser/mod.rs	88.88%	0 Missing and 5 partials ⚠️
src/ast/ddl.rs	90.90%	0 Missing and 3 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2317      +/-   ##
==========================================
+ Coverage   82.18%   82.20%   +0.01%     
==========================================
  Files          42       42              
  Lines       35253    35314      +61     
  Branches    35253    35314      +61     
==========================================
+ Hits        28974    29029      +55     
+ Misses       2717     2716       -1     
- Partials     3562     3569       +7     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[LucaCappelletti94]

Do please also add some seed entries for the fuzzer corpus, so it can better search bugs that are relevant to this syntax.

[LucaCappelletti94]

Most likely "A repeated clause errors." should be dropped from the description once the parser keeps repeats, given the pg_query reference.

[LucaCappelletti94]

I found the following regression with main, apparently these changes broke the parsing of this mysql syntax:

#[test]
fn parse_flush_preserves_keyword_table_names() {
    for sql in [
        "FLUSH TABLES handler WITH READ LOCK",
        "FLUSH TABLES validator WITH READ LOCK",
    ] {
        mysql_and_generic().verified_stmt(sql);
    }
}

[fmguerreiro]

I found the following regression with main, apparently these changes broke the parsing of this mysql syntax:

thanks again! fixed

[LucaCappelletti94]

LGTM! I will rebase it and then it should be good to go.

cc @alamb