Repository navigation
feat: add IcebergCatalogTableProvider::new_with_schema #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love the fact that the public API of this project makes incorrect state representable.
People here can choose to shoot themselves in the foot and pass a
schemathat has nothing to do with the actual table. This problem goes a bit beyond just this new constructor method, and it's rooted into theIcebergCatalogTableProviderstruct fields themselves.One thing I notice is that
IcebergCatalogTableProvideronly needs theCatalogitself because it's required for constructing anIcebergCommitExec. It's a bit unfortunate thatCatalogis dangerously close to a god object in charge of everything, some interface segregation there could have prevented from needing to thread it around everywhere.Given that
Catalogcontains so many methods and not necessarily related functionality, I wonder if it'd make sense to have it be part of the DataFusion'sSessionConfig.extensionsand thread it around as part of the context, rather than manually requiring it to be stored in every struct.