Repository navigation
docs: [branch-1.2] document known differences new in 1.2.0 in the upgrade guide - #7287
Merged
andygrove merged 1 commit intoOct 28, 2026
Merged
Conversation
andygrove
marked this pull request as ready for review
October 28, 2026 09:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #7204. Documents #7203, #5022 and #6936 instead of fixing them in 1.2.0.
Rationale for this change
#7203, #5022 and #6936 are differences from Spark that 1.1.0 did not have, found in the audit tracked in #7204. None has a fix, and none will be in 1.2.0, so the upgrade guide tells users about them and gives the setting that avoids each one.
What changes are included in this PR?
A new section, "Known Differences From Spark That Are New in 1.2.0", in
docs/source/user-guide/latest/migration-guide.mdunder "Upgrading to Comet 1.2.0". It covers:collect_setoverFLOATorDOUBLEnext tocount(DISTINCT ...)on Spark before 4.2 (signed zeros andNaN).RANGEwindow frame over aDATEcolumn with an offset of about 92 million days or more.min/maxunder-report memory in hash aggregates #6936: nativeSTRINGandBINARYminandmaxunder-reporting memory in a hash aggregate.The guide says it leaves out correctness fixes, so the section's opening paragraph explains why these three are listed.
How are these changes tested?
Prettier passes on the file. The text comes from the issues, the code on
branch-1.2and the audit in #7204. I did not run a query for any of them on this branch, so these points are unchecked:spark.comet.exec.strictFloatingPoint=trueshould make thecount(DISTINCT ...)shape fall back for collect_set over floats beside count(DISTINCT) diverges from Spark on signed zeros and NaN #7203. It is the existing gate inCometCollectSet.getSupportLevel, but I did not run that query.spark.sql.execution.useObjectHashAggregateExec=falsesetting for Native string and binarymin/maxunder-report memory in hash aggregates #6936 is the workaround given in the issue.mainhas an "Upgrading to Comet 1.2.0" section too. It needs the same text, so a counterpart PR againstmainis still to do.