Repository navigation
Conversation
Adaptive query planning became the default in apache#2315, so the TPC-DS workflow has been running AQE while its job names and comments still said static planner. Set the planner flag explicitly and update the benchmarks README, which also still described a non-empty skip list and the fixed apache#2047.
The leg passed no planner flag, so once adaptive planning became the default it duplicated the "AQE on" leg and the static planner lost TPC-H coverage.
andygrove
changed the title
Add static planner legs alongside the adaptive ones, each at one and four partitions per task, so both planners are gated on all 99 queries.
andygrove
changed the title
Member
Author
|
This might use up too much CI resource. I wonder if we should introduce a merge queue and only run the heavy jobs there? DataFusion core and Comet both do this. WDYT @milenkovicm ? |
andygrove
marked this pull request as draft
October 26, 2026 13:49
Contributor
|
i have no objections on merge queue, please do |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A. Follow-up to #2315.
Rationale for this change
#2315 made adaptive query planning the default. Neither benchmark workflow was updated to match, so the static planner has had no CI coverage since then:
The benchmarks README is also stale. It points at #2047, which is closed, and describes a skip list grouped by cause, but the list is now empty.
What changes are included in this PR?
.github/workflows/tpcds.yml: run four legs, the static planner and the adaptive planner, each at 1 and 4 partitions per task. Every leg setsballista.planner.adaptive.enabledexplicitly so the job labels stay correct if the default changes..github/workflows/tpch.yml: give the "AQE off" leg-c ballista.planner.adaptive.enabled=falseso it runs the static planner again.benchmarks/README.md: update the TPC-DS "Skip list" and "CI" sections to match.Are there any user-facing changes?
No. CI and docs only.