Clear residual buffer chars in TextStringBuilder shrink and clear paths#746
Merged
garydgregory merged 2 commits intoJun 2, 2026
Merged
Conversation
Member
|
Hello @dxbjavid |
Contributor
Author
|
Added TextStringBuilderClearTest, modeled on StrBuilderClearTest. Covers clear, delete, the replace shrink branch, and setLength, plus the readFrom(Reader) and serialization leak paths. All six tail-clearing cases fail on the unpatched buffer and pass with the fix. |
garydgregory
changed the title
garydgregory
reviewed
Jun 2, 2026
| * A Reader that, upon reading, inspects the char array it has been given access to (positions beyond offset+len that may contain stale data), records them, | ||
| * then supplies its normal data. | ||
| */ | ||
| static class SpyReader extends Reader { |
Member
There was a problem hiding this comment.
In the future, reduce the copy pasta please, you've already added this class in a previous PR.
See c6d867e
garydgregory
added a commit
that referenced
this pull request
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TextStringBuilder.clear(), deleteImpl(), the replaceImpl() shrink branch, and setLength(int) all lower the logical size without wiping the now-unused tail of the internal char[], which stays readable through serialization (the buffer is non-transient) and through readFrom() handing the raw array to a Readable. This ports the same fill-with-NUL hardening already merged for StrBuilder in #741, #742, and #744 to its non-deprecated counterpart.