Skip to content

Migrate interaction tag to JLine 2 API - #107

Merged
garydgregory merged 1 commit into
apache:dependabot/maven/jline-jline-2.14.6from
skrcode:jaipilot/jline-2-api
Sep 8, 2026
Merged

garydgregory merged 1 commit into
apache:dependabot/maven/jline-jline-2.14.6from
skrcode:jaipilot/jline-2-api

Conversation

@skrcode

@skrcode skrcode commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

This completes the JLine 2.14.6 upgrade proposed in #104.

JLine 2 moved the console, history, and completion APIs used by AskTag. This migration:

  • uses jline.console.ConsoleReader
  • preserves the shared in-memory history with MemoryHistory
  • rebuilds history-based completions from the JLine 2 History.Entry iterator
  • replaces SimpleCompletor with StringsCompleter

The existing prompt, default-answer, predefined-completion, and cross-invocation history behavior is retained.

Verification

  • mvn -B --no-transfer-progress -pl jelly-tags/interaction -am clean verify on JDK 8
  • the same reactor build on JDK 25
  • 133 Commons Jelly core tests passed on each JDK
  • interaction module compiled and packaged on both the minimum and current Java runtimes
  • Apache RAT, Animal Sniffer, build-plan checks, and SBOM generation completed
  • git diff --check

Built and verified with JAIPilot:

  • Skills: jaipilot-maintainer-intent, jaipilot-fast-execution, and jaipilot-review-diff
  • Execution profile: gpt-5.6-sol · xhigh · fast

@garydgregory
garydgregory marked this pull request as draft September 8, 2026 10:28
@garydgregory
garydgregory marked this pull request as ready for review September 8, 2026 10:39
@garydgregory
garydgregory merged commit e52e89f into apache:dependabot/maven/jline-jline-2.14.6 Sep 8, 2026
7 checks passed
@garydgregory

Copy link
Copy Markdown
Member

Thank you @skrcode , merged 🚀 Your verification steps are wrong. Please verify by following the steps in the PR template.

garydgregory pushed a commit that referenced this pull request Sep 8, 2026
* Bump jline:jline from 0.9.5 to 2.14.6

Bumps [jline:jline](https://github.com/jline/jline2) from 0.9.5 to 2.14.6.
- [Changelog](https://github.com/jline/jline2/blob/master/CHANGELOG.md)
- [Commits](https://github.com/jline/jline2/commits/jline-2.14.6)

---
updated-dependencies:
- dependency-name: jline:jline
  dependency-version: 2.14.6
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Migrate interaction tag to JLine 2 API (#107)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Suraj Rajan <surajkrajan95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants