CEP-45: Fixes and improvements to MT migration logic - #5119
Open
iamaleksey wants to merge 4 commits into
Open
Conversation
Member
Author
|
The optional fifth commit (context above): iamaleksey@c19e3e9 |
bdeggleston
approved these changes
Sep 4, 2026
bdeggleston
left a comment
Member
There was a problem hiding this comment.
+1 - I agree we should avoid batching if possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the following TCM-related issues in MT migration logic:
The original motivation for this patch set was to deal with the storm of transformations issued on repair jobs' completions contending and overwhelming TCM.
The build that exposed this problem, however, did not include the following two patch sets that are intended to help with just this sort of problem:
So I suspect that commit (5) is no longer necessary. I'm also not a massive fan of having two inconsistent approaches (per-job callback for Accord, per-session callback for MT) co-existing. So my preference is to include all the fixes and improvements except the last one, and revisit committing the optional one only if a build with those trunk TCM improvements still exhibits contention problems.