CASSANDRA-21630: Upgrade async-profiler from 4.2 to 4.5 - #5116
Conversation
b365489 to
a59358d
Compare
|
I guess we also need to update these lines in the docs:
And rest looks good to me. cc @smiklosovic |
|
yes, I think we should update the docs and I would put some placeholder there instead of the exact version, to not update them every time we update the library |
a59358d to
efbdeb2
Compare
|
Updated both lines in the docs to use a placeholder instead of the hardcoded version. |
|
Two last comments from my side:
|
|
hi @Suhel0328 to what @arvindKandpal-ksolves mentioned in his comment about updating the versions, just replace "4.2" with some kind of a placeholder (X.Y) instead of new version, we would need to update this every time we update this library and that is not necessary. edit: ah ... right, you already did! Thank you :) Ignore this comment then. |
|
Hi @netudima, updated as per the feedback! |
Upgrades async-profiler from 4.2 to 4.5.
Checked the changelogs for 4.3, 4.4, and 4.5 for anything that could affect our integration. The only breaking changes are removal of the
checkcommand, thesafemodeoption,cstack=lbr, and a format change tootlpoutput — none of which appear anywhere inAsyncProfilerService.javaorAsyncProfileCommandGroup.java. The actual Java API surface used is justAsyncProfiler.getInstance()and.execute(String), which has no documented breaking changes across these versions.Tested this beyond just reading changelogs:
nodetool profilecommands.CASSANDRA-21630