Skip to content

CASSANDRA-21630: Upgrade async-profiler from 4.2 to 4.5 - #5116

Open
Suhel0328 wants to merge 2 commits into
apache:cassandra-6.0from
Suhel0328:CASSANDRA-21630-6.0
Open

CASSANDRA-21630: Upgrade async-profiler from 4.2 to 4.5#5116
Suhel0328 wants to merge 2 commits into
apache:cassandra-6.0from
Suhel0328:CASSANDRA-21630-6.0

Conversation

@Suhel0328

Copy link
Copy Markdown
Contributor

Upgrades async-profiler from 4.2 to 4.5.

Checked the changelogs for 4.3, 4.4, and 4.5 for anything that could affect our integration. The only breaking changes are removal of the check command, the safemode option, cstack=lbr, and a format change to otlp output — none of which appear anywhere in AsyncProfilerService.java or AsyncProfileCommandGroup.java. The actual Java API surface used is just AsyncProfiler.getInstance() and .execute(String), which has no documented breaking changes across these versions.

Tested this beyond just reading changelogs:

  • Confirmed the 4.5 Maven artifact resolves correctly and the build compiles cleanly against it.
  • Ran an isolated test calling the async-profiler Java API directly (outside Cassandra) to confirm the native library loads and a full start/stop profiling cycle works.
  • Ran a real Cassandra node from this build and exercised it through the actual nodetool profile commands.
  • Ran a differential test with the old 4.2 jar swapped in under identical conditions to rule out environment-specific noise — both versions behaved identically in every test.

CASSANDRA-21630

@arvindKandpal-ksolves

Copy link
Copy Markdown
Contributor

@netudima

netudima commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

yes, I think we should update the docs and I would put some placeholder there instead of the exact version, to not update them every time we update the library

@Suhel0328

Copy link
Copy Markdown
Contributor Author

Updated both lines in the docs to use a placeholder instead of the hardcoded version.

cc: @netudima @arvindKandpal-ksolves

@netudima

netudima commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Two last comments from my side:

  1. please re-generate ide/nbproject/project.xml (there is a shell script for it) to fetch the updated version
  2. also please exclude CHANGES.txt updates from the MR, we will add it during a merge. It frequently causes merge conflicts when it is a part of the commit.

@smiklosovic

smiklosovic commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

hi @Suhel0328

to what @arvindKandpal-ksolves mentioned in his comment about updating the versions, just replace "4.2" with some kind of a placeholder (X.Y) instead of new version, we would need to update this every time we update this library and that is not necessary.

edit: ah ... right, you already did! Thank you :) Ignore this comment then.

@Suhel0328

Copy link
Copy Markdown
Contributor Author

Hi @netudima, updated as per the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants