Repository navigation
Conversation
Because otel follows semver, the API package is guarenteed until the next bump. This overly constrained version will require more churn to keep up to date, and make it difficult for users of the package to keep their deps up to date. https://opentelemetry.io/docs/specs/otel/versioning-and-stability/
There was a problem hiding this comment.
📋 Review Summary
This PR relaxes the upper version bound for opentelemetry-api, opentelemetry-sdk, and opentelemetry-exporter-otlp-proto-http in ml_adk_dependency from <1.43 to <2.0. The change is clean, safe, and aligns with OpenTelemetry's 1.x semantic versioning guarantees as well as Beam's convention of keeping test extra dependency bounds open.
🔍 General Feedback
- LGTM! No issues found.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40973 +/- ##
==========================================
+ Coverage 79.83% 80.09% +0.25%
==========================================
Files 494 494
Lines 83575 83614 +39
==========================================
+ Hits 66722 66970 +248
+ Misses 16853 16644 -209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Because otel follows semver, the API package is guarenteed until the next bump. This overly constrained version will require more churn to keep up to date, and make it difficult for users of the package to keep their deps up to date.
https://opentelemetry.io/docs/specs/otel/versioning-and-stability/