Skip to content

Update opentelemetry package version constraints - #40973

Open
aebrahim wants to merge 1 commit into
apache:masterfrom
aebrahim:patch-2
Open

aebrahim wants to merge 1 commit into
apache:masterfrom
aebrahim:patch-2

Conversation

@aebrahim

@aebrahim aebrahim commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Because otel follows semver, the API package is guarenteed until the next bump. This overly constrained version will require more churn to keep up to date, and make it difficult for users of the package to keep their deps up to date.

https://opentelemetry.io/docs/specs/otel/versioning-and-stability/

Because otel follows semver, the API package is guarenteed until the next bump. This overly constrained version will require more churn to keep up to date, and make it difficult for users of the package to keep their deps up to date.

https://opentelemetry.io/docs/specs/otel/versioning-and-stability/
@github-actions github-actions Bot added python size/xs XS: <10 lines changed labels Nov 3, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR relaxes the upper version bound for opentelemetry-api, opentelemetry-sdk, and opentelemetry-exporter-otlp-proto-http in ml_adk_dependency from <1.43 to <2.0. The change is clean, safe, and aligns with OpenTelemetry's 1.x semantic versioning guarantees as well as Beam's convention of keeping test extra dependency bounds open.

🔍 General Feedback

  • LGTM! No issues found.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @claudevdm for label python.
Backup reviewer: shunping (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.09%. Comparing base (12bbb17) to head (9d249d3).
⚠️ Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40973      +/-   ##
==========================================
+ Coverage   79.83%   80.09%   +0.25%     
==========================================
  Files         494      494              
  Lines       83575    83614      +39     
==========================================
+ Hits        66722    66970     +248     
+ Misses      16853    16644     -209     
Flag Coverage Δ
python 80.09% <ø> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants