Repository navigation
Authenticate before pushing. - #40959
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the beam_Upgrade_GCP_BOM.yml and update_python_dependencies.yml workflows to configure git authentication via gh auth setup-git before pushing branches, which is required because actions/checkout runs with persist-credentials: false. It also replaces the broken gitDiff vs gitdiff variable check with a clean if ! git diff --cached --quiet; then check.
🔍 General Feedback
- The changes align the commit and push control flow with
beam_Upgrade_Google_Ads_Version.ymland resolve both the missing git credentials issue and the case-mismatch bug (gitdiffvsgitDiff) in the previous diff check. - Everything looks clean, minimal, and ready to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Hi @tvalentyn, is #40960 replacing this one? Thanks |
|
No, #40960 is autogenerated PR to upgrade dependencies; it was not being created before because the tool didn't have permissions to push a PR out. My commit from this PR was included there by necessity to test the autogeneration. It would be cleaner to separate the changes. |
Use similar control flow as .github/workflows/beam_Upgrade_Google_Ads_Version.yml