Skip to content

Authenticate before pushing. - #40959

Merged
tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:permissions
Nov 3, 2026
Merged

tvalentyn merged 1 commit into
apache:masterfrom
tvalentyn:permissions

Conversation

@tvalentyn

@tvalentyn tvalentyn commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

@github-actions github-actions Bot added build size/xs XS: <10 lines changed labels Nov 3, 2026
@tvalentyn
tvalentyn requested a review from derrickaw November 3, 2026 01:39

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the beam_Upgrade_GCP_BOM.yml and update_python_dependencies.yml workflows to configure git authentication via gh auth setup-git before pushing branches, which is required because actions/checkout runs with persist-credentials: false. It also replaces the broken gitDiff vs gitdiff variable check with a clean if ! git diff --cached --quiet; then check.

🔍 General Feedback

  • The changes align the commit and push control flow with beam_Upgrade_Google_Ads_Version.yml and resolve both the missing git credentials issue and the case-mismatch bug (gitdiff vs gitDiff) in the previous diff check.
  • Everything looks clean, minimal, and ready to merge.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@tvalentyn

Copy link
Copy Markdown
Contributor Author

@derrickaw

Copy link
Copy Markdown
Collaborator

Hi @tvalentyn, is #40960 replacing this one? Thanks

@tvalentyn

Copy link
Copy Markdown
Contributor Author

No, #40960 is autogenerated PR to upgrade dependencies; it was not being created before because the tool didn't have permissions to push a PR out. My commit from this PR was included there by necessity to test the autogeneration. It would be cleaner to separate the changes.

@tvalentyn
tvalentyn merged commit 1eb4a88 into apache:master Nov 3, 2026
12 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants