Skip to content

Skip WindowInto(GlobalWIndows()) elementwise if upstream pcoll is already global window in Write transform #40911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abacn wants to merge 2 commits into
base: master
Choose a base branch
from
+6 −2
Open

Skip WindowInto(GlobalWIndows()) elementwise if upstream pcoll is already global window in Write transform #40911

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9b5a67
Skip WindowInto(GlobalWIndows()) elementwise if upstream pcoll
Abacn Oct 30, 2026
6d26e8c
Fix pcoll.windowing AssertError when pcoll.producer absent
Abacn Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions sdks/python/apache_beam/io/iobase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1189,9 +1189,12 @@ def _expand_bounded(self, pcoll, min_shards):
keyed_pcoll = pcoll | core.Map(lambda x: (None, x))
else:
keyed_pcoll = pcoll | core.ParDo(_RoundRobinKeyFn(), count=min_shards)
# pcoll.windowing checks pcoll.producer which may be absent when expand()
# is called directly (e.g. in tests)
if pcoll.producer is None or not keyed_pcoll.windowing.is_default():
keyed_pcoll = keyed_pcoll | core.WindowInto(window.GlobalWindows())
write_result_coll = (
keyed_pcoll
| core.WindowInto(window.GlobalWindows())
| core.GroupByKey()
| 'WriteBundles' >> core.ParDo(
_WriteKeyedBundleDoFn(self.sink), AsSingleton(init_result_coll)))
Expand All @@ -1200,9 +1203,10 @@ def _expand_bounded(self, pcoll, min_shards):
"*** WriteImpl min_shards undef so it's 1, and we write per Bundle")
min_shards = 1

if pcoll.producer is None or not pcoll.windowing.is_default():
pcoll = pcoll | core.WindowInto(window.GlobalWindows())
write_result_coll = (
pcoll
| core.WindowInto(window.GlobalWindows())
| 'WriteBundles' >> core.ParDo(
_WriteBundleDoFn(self.sink), AsSingleton(init_result_coll))
| 'Pair' >> core.Map(lambda x: (None, x))
Expand Down
Loading