Repository navigation
Cherrypick #40892 Drop legacy options from HF Inference api - #40900
Merged
Merged
Conversation
github-actions
Bot
added
Next Action: Reviewers
python
size/xs
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR cleanly cherry-picks #40892 onto the release-2.78 branch to remove the deprecated options payload parameter from Hugging Face Inference API requests in _InferenceAPIHandler.run_inference. The change is minimal, accurate, and ready to merge.
🔍 General Feedback
- The cherry-pick matches the original fix in #40892 and properly omits the post-commit trigger file modification.
- Note for future cleanup on
master:InferenceAPIEmbeddings.get_ptransform_for_processingstill populatesself.inference_argswith'wait_for_model'and'use_cache', which are now unused by_InferenceAPIHandler.run_inference.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Abacn
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.