[robertwb]

No description provided.

[github-actions]

📋 Review Summary

This PR registers _FilteringIterable with FastPrimitivesCoderImpl.register_iterable_like_type, allowing FastPrimitivesCoder (including its deterministic variant) to natively encode side input iterables without falling back to pickling or failing deterministic encoding checks.

🔍 General Feedback

• The implementation in sideinputs.py is clean and aligns with how other lazy iterable wrappers (such as _ConcatSequence and _AbstractIterable) are registered with FastPrimitivesCoderImpl.
• Consider adding a unit test in sideinputs_test.py or coders_test_common.py to explicitly verify encoding and deterministic encoding of _FilteringIterable (e.g., passing an AsIter side input directly into a transform requiring deterministic encoding).

---

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.83%. Comparing base (0f1ac43) to head (d0da24b).
⚠️ Report is 20 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #40888       +/-   ##
===========================================
+ Coverage        0   79.83%   +79.83%     
===========================================
  Files           0      494      +494     
  Lines           0    83575    +83575     
===========================================
+ Hits            0    66719    +66719     
- Misses          0    16856    +16856     

Flag	Coverage Δ
python	79.83% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Assigning reviewers:

R: @jrmccluskey for label python.
Backup reviewer: tvalentyn (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

This pull request likely touches a core component ("core" label). Please review with scrutiny.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).