Repository navigation
Conversation
Contributor
|
Twister2 runner has long been deprecated. It may be time to sunset it. |
Contributor
Author
|
Closing this as superseded by #40869, which removed the Twister2 runner and its CI workflow. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twister2 was removed from master in #40869, which supersedes this draft.
Twister2's local test runner shares fixed worker ports and process-wide state between pipelines. Beam's parallel JUnit runner currently starts several validation methods at once, which can interfere during graph construction. This CI run failed in
DAGMutableGraph.nodes()before reaching the job timeout.Set
beam.validatesRunner.parallelThreads=1for the Twister2 batch validation task. This serializes itsValidatesRunnermethods while retaining the existing test selection and general test-thread setting.In an isolated container network, the default parallel run reproduced the same graph-iteration stack. The same selected pipeline and assertion cases passed with the new setting. Evaluated Gradle settings and live worker threads confirmed the change. The full scheduled suite and its timeout behavior remain unverified locally.