Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40863 +/- ##
===========================================
+ Coverage 0 80.08% +80.08%
===========================================
Files 0 494 +494
Lines 0 83574 +83574
===========================================
+ Hits 0 66927 +66927
- Misses 0 16647 +16647
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bvolpato
force-pushed
the
bvolpato/cleanup-yaml-bigquery-datasets
branch
from
October 28, 2026 23:57
6ada839 to
f0f3cea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
YAML integration fixtures use
ExitStack. If a later fixture fails during setup, the exception reaches the BigQuery fixture atyieldand skips its dataset deletion. In this run, datasets were created before Bigtable setup failed, and their cleanup was never reached.Move dataset cleanup into
finallyafter creation, covering both optional table setup and errors from the test or another fixture. The fixture now calls deletion as the stack unwinds, using the existing request to delete the dataset and its contents.Focused regression cases failed against the original helper because deletion was never called, then passed with the fix. They use the real Beam and BigQuery API modules with mocked cloud clients. Formatting and lint checks passed, including a check that missing optional dependencies skip the tests. No live cloud resources were used.