Skip to content

[python] - update deferredSeries.duplicated logic - #40846

Open
derrickaw wants to merge 1 commit into
apache:masterfrom
derrickaw:20261026_deferredSeries
Open

derrickaw wants to merge 1 commit into
apache:masterfrom
derrickaw:20261026_deferredSeries

Conversation

@derrickaw

Copy link
Copy Markdown
Collaborator

Fix: #40814

@derrickaw

Copy link
Copy Markdown
Collaborator Author

/gemini review

@github-actions github-actions Bot added python size/s S: 10-49 lines changed labels Oct 27, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR fixes DeferredSeries.duplicated() by removing the invalid column subscripting on the DeferredSeries returned by DeferredDataFrame.duplicated(), and properly preserves the Series.name attribute across both DeferredSeries.duplicated() and DeferredSeries.drop_duplicates(). It also adds unit test coverage for named and unnamed Series and re-enables the Series.duplicated pandas doctest.

🔍 General Feedback

  • The fix is clean, idiomatic, and accurately mirrors pandas behavior for Series.name preservation when delegating to DataFrame operations.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@codecov

codecov Bot commented Oct 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (2213e54) to head (43d2ca8).
⚠️ Report is 42 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #40846       +/-   ##
===========================================
+ Coverage        0   79.91%   +79.91%     
===========================================
  Files           0      493      +493     
  Lines           0    83485    +83485     
===========================================
+ Hits            0    66713    +66713     
- Misses          0    16772    +16772     
Flag Coverage Δ
python 79.91% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
derrickaw marked this pull request as ready for review October 27, 2026 19:36
@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @tvalentyn for label python.
Backup reviewer: claudevdm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: DeferredSeries.duplicated() raises WontImplementError due to incorrect column indexing

1 participant