Repository navigation
Conversation
|
/gemini review |
There was a problem hiding this comment.
📋 Review Summary
This PR fixes DeferredSeries.duplicated() by removing the invalid column subscripting on the DeferredSeries returned by DeferredDataFrame.duplicated(), and properly preserves the Series.name attribute across both DeferredSeries.duplicated() and DeferredSeries.drop_duplicates(). It also adds unit test coverage for named and unnamed Series and re-enables the Series.duplicated pandas doctest.
🔍 General Feedback
- The fix is clean, idiomatic, and accurately mirrors pandas behavior for
Series.namepreservation when delegating toDataFrameoperations.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40846 +/- ##
===========================================
+ Coverage 0 79.91% +79.91%
===========================================
Files 0 493 +493
Lines 0 83485 +83485
===========================================
+ Hits 0 66713 +66713
- Misses 0 16772 +16772
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fix: #40814