Repository navigation
[Python] Handle translated Azure missing-blob errors in exists - #40845
Draft
crisfiorini-oss wants to merge 1 commit into
Draft
crisfiorini-oss wants to merge 1 commit into
crisfiorini-oss wants to merge 1 commit into
Conversation
crisfiorini-oss
force-pushed
the
fix/azure-blob-exists-404
branch
from
October 28, 2026 16:38
0045e72 to
4b0b978
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BlobStorageIO.exists currently catches ResourceNotFoundError, but _blob_properties translates that exception into BlobStorageError. A missing blob therefore raises instead of returning False, causing FileBasedSink.pre_finalize / WriteToText to fail for a fresh Azure Blob destination.
Catch the translated BlobStorageError and check its code. Preserve failures for every non-404 response. Reuse the existing Azure filesystem and exception translation; no client, retry or pipeline changes.
Validation: the new missing-blob regression fails against the unmodified Beam 2.72 SDK with BlobStorageError(None, 404). All eight tests in blobstorageio_test.py (four existing path cases and four existence cases) pass with the fix using Beam 2.72 and the Azure SDK. Coverage includes existing blobs, the real ResourceNotFoundError-to-BlobStorageError translation, authorization failures and non-404 translated failures. Full suites run in CI.
The failure was reproduced on Flink 1.20 using the Beam 2.72 portable Python SDK with Azure workload identity; no credentials are needed for the regression tests.
Current CI gate (2026-10-28)
Rebased onto current master and pushed head
4b0b9787af75e8fa76b85c63de186da413a5b4e0; the two-file fix and existing fixture reuse are unchanged. The Python workflows, including PreCommit Python, await Apache maintainer approval for this contributor. Successful label/metadata checks do not establish Python test success. The upstream workflow also uses Apache's self-hosted runners, so an unmodified fork run cannot provide those runners. Keep this PR draft until the upstream test workflows actually run and pass.Downstream independence (2026-10-28)
The downstream runtime maintains this correction and its regression tests in obin-ai/module-beam-runner #7, with image builds and tests in downstream CI. This upstream contribution remains optional; Apache workflow approval, merging and release timing do not block downstream delivery. This does not claim that the pending Apache test workflows passed.