Repository navigation
[Experimental] Update ONNX extras - #40821
jrmccluskey wants to merge 6 commits into
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the onnx extra and ml_base_core dependency bounds in setup.py, re-enables the ONNX postcommit test tasks in tox.ini and build.gradle (testing lower-bound 119 and latest), and disables multi-process model sharing on OnnxModelHandlerNumPy since onnxruntime.InferenceSession manages its own native thread pools and cannot be safely proxied across processes.
🔍 General Feedback
- The changes to
OnnxModelHandlerNumPyand the updated dependency/tox configurations are well-structured and clearly documented. - Note that the branch currently has a merge conflict with recent
masterchanges (from PR #40752) in.github/trigger_files/beam_PostCommit_Python_Dependency.jsonand adjacent lines insdks/python/test-suites/tox/py311/build.gradle/sdks/python/tox.ini, so a rebase onmasterwill be needed. - One minor cleanup opportunity was noted in
tox.iniregarding an obsoleteonnx<1.19.0pin intestenv:py311-ml.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @tvalentyn for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40821 +/- ##
===========================================
+ Coverage 0 79.89% +79.89%
===========================================
Files 0 493 +493
Lines 0 83479 +83479
===========================================
+ Hits 0 66695 +66695
- Misses 0 16784 +16784
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Modernize the ONNX extras group and re-enable testing, which has been disabled since 2024. Prior to updating, the onnx extras group was not able to install on any currently supported Python version.