Skip to content

Fix PreCommit Java Solace IO Direct workflow - #40815

Open
Amar3tto wants to merge 1 commit into
masterfrom
fix-solace
Open

Amar3tto wants to merge 1 commit into
masterfrom
fix-solace

Conversation

@Amar3tto

Copy link
Copy Markdown
Collaborator

@Amar3tto
Amar3tto requested a review from damccorm October 26, 2026 16:03

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR fixes the PreCommit Java Solace IO Direct GitHub Actions workflow on ubuntu-latest runners by configuring the default Java version via setup-environment-action and removing the default GitHub Maven settings.xml file. The change aligns with established patterns across other Apache Beam Java workflows running on GitHub-hosted runners.

🔍 General Feedback

  • Properly sets java-version: default for setup-environment-action on the ubuntu-latest runner.
  • Includes the standard workaround (rm ~/.m2/settings.xml || true) to prevent conflicts with net.linguica.gradle.maven.settings.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

@github-actions github-actions Bot added build size/xs XS: <10 lines changed labels Oct 26, 2026
- name: Remove default github maven configuration
# This is a workaround for a decryption issue between Beam's
# net.linguica.gradle.maven.settings plugin and GitHub's Maven settings.
run: rm ~/.m2/settings.xml || true

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this just be part of setup-environment-action?

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @derrickaw for label build.
Backup reviewer: damccorm (if the main reviewer is unresponsive, you can escalate to them by tagging their username)

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The PreCommit Java Solace IO Direct job is flaky

2 participants