Repository navigation
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR fixes the PreCommit Java Solace IO Direct GitHub Actions workflow on ubuntu-latest runners by configuring the default Java version via setup-environment-action and removing the default GitHub Maven settings.xml file. The change aligns with established patterns across other Apache Beam Java workflows running on GitHub-hosted runners.
🔍 General Feedback
- Properly sets
java-version: defaultforsetup-environment-actionon theubuntu-latestrunner. - Includes the standard workaround (
rm ~/.m2/settings.xml || true) to prevent conflicts withnet.linguica.gradle.maven.settings.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
| - name: Remove default github maven configuration | ||
| # This is a workaround for a decryption issue between Beam's | ||
| # net.linguica.gradle.maven.settings plugin and GitHub's Maven settings. | ||
| run: rm ~/.m2/settings.xml || true |
There was a problem hiding this comment.
Should this just be part of setup-environment-action?
|
Assigning reviewers: R: @derrickaw for label build. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fixes #40734
Successful run: https://github.com/apache/beam/actions/runs/40353530938