Repository navigation
Fix Clean Up GCP Resources workflow - #40813
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR updates .test-infra/tools/stale_cbt_instances_cleaner.sh to include bt-cdc-tests in the cleanup templates and disables Bigtable change streams on tables before attempting to delete stale instances. The changes are clean, modernize the shell syntax, and directly resolve the instance deletion failures in the GCP resource cleanup workflow.
🔍 General Feedback
- Disabling change streams via
--clear-change-stream-retention-periodprior tocbt deleteinstanceproperly addresses Bigtable's restriction against deleting instances containing tables with active change streams. - Shell modernizations (
$(...)command substitutions and proper variable quoting) improve script safety and readability.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39772
Successful run: https://github.com/apache/beam/actions/runs/40346155428/job/121653509104