Repository navigation
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the documentation and --file_to_stage pipeline option help text to clarify that staged files are downloaded to $SEMI_PERSISTENT_DIRECTORY/staged/ on workers.
🔍 General Feedback
- The path correction accurately aligns with how
boot.gomaterializes staged artifacts (filepath.Join(*semiPersistDir, "staged")) and howsdk_worker_main.pylocates the staged directory. - One minor issue in the documentation code snippet where
os.environ.get('SEMI_PERSISTENT_DIRECTORY')without a fallback or brackets could raise a confusingTypeErrorinos.path.joinif the environment variable is unset.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
…-dependencies.md Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40761 +/- ##
==========================================
- Coverage 80.04% 79.91% -0.14%
==========================================
Files 490 493 +3
Lines 82916 83473 +557
==========================================
+ Hits 66373 66705 +332
- Misses 16543 16768 +225
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
LGTM |
Files are staged in $SEMI_PERSIST_DIR/staged, not $SEMI_PERSIST_DIR