Skip to content

Correct typo in the staged path. - #40761

Open
tvalentyn wants to merge 2 commits into
apache:masterfrom
tvalentyn:staged_path
Open

tvalentyn wants to merge 2 commits into
apache:masterfrom
tvalentyn:staged_path

Conversation

@tvalentyn

@tvalentyn tvalentyn commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Files are staged in $SEMI_PERSIST_DIR/staged, not $SEMI_PERSIST_DIR

@github-actions github-actions Bot added python website size/xs XS: <10 lines changed labels Oct 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📋 Review Summary

This PR updates the documentation and --file_to_stage pipeline option help text to clarify that staged files are downloaded to $SEMI_PERSISTENT_DIRECTORY/staged/ on workers.

🔍 General Feedback

  • The path correction accurately aligns with how boot.go materializes staged artifacts (filepath.Join(*semiPersistDir, "staged")) and how sdk_worker_main.py locates the staged directory.
  • One minor issue in the documentation code snippet where os.environ.get('SEMI_PERSISTENT_DIRECTORY') without a fallback or brackets could raise a confusing TypeError in os.path.join if the environment variable is unset.

💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.

Comment thread website/www/site/content/en/documentation/sdks/python-pipeline-dependencies.md Outdated
@tvalentyn

Copy link
Copy Markdown
Contributor Author

R: @tarun-google

@github-actions

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

…-dependencies.md

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@codecov

codecov Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.91%. Comparing base (a8d6afd) to head (4262b47).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #40761      +/-   ##
==========================================
- Coverage   80.04%   79.91%   -0.14%     
==========================================
  Files         490      493       +3     
  Lines       82916    83473     +557     
==========================================
+ Hits        66373    66705     +332     
- Misses      16543    16768     +225     
Flag Coverage Δ
python 79.91% <ø> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tarun-google

Copy link
Copy Markdown
Contributor

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

python size/xs XS: <10 lines changed website

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants