Skip to content

Fix TestBigQueryEndpoint to mock gcp_bigquery module instead of gcp_bigquery.Client #40746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrmccluskey merged 1 commit into from
Oct 23, 2026
Merged

Fix TestBigQueryEndpoint to mock gcp_bigquery module instead of gcp_bigquery.Client #40746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions sdks/python/apache_beam/io/gcp/bigquery_tools_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,9 +335,10 @@ def test_bigquery_client_uses_endpoint(self, unused_mock_credentials):
self.assertEqual(client.url, 'https://bq.example.com/bigquery/v2/')

@mock.patch.object(bigquery_tools.auth, 'get_service_credentials')
@mock.patch.object(bigquery_tools.gcp_bigquery, 'Client')
@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery')
def test_wrapper_applies_endpoint_to_both_clients(
self, mock_gcp_client, unused_mock_credentials):
self, mock_gcp_bq, unused_mock_credentials):
mock_gcp_client = mock_gcp_bq.Client
options = PipelineOptions(['--bigquery_endpoint=https://bq.example.com'])
wrapper = bigquery_tools.BigQueryWrapper(pipeline_options=options)
self.assertEqual(wrapper.client.url, 'https://bq.example.com/bigquery/v2/')
Expand All @@ -347,8 +348,9 @@ def test_wrapper_applies_endpoint_to_both_clients(
mock_gcp_client.call_args.kwargs['client_options'],
{'api_endpoint': 'https://bq.example.com'})

@mock.patch.object(bigquery_tools.gcp_bigquery, 'Client')
def test_gcp_client_merges_endpoint_and_quota_project(self, mock_gcp_client):
@mock.patch('apache_beam.io.gcp.bigquery_tools.gcp_bigquery')
def test_gcp_client_merges_endpoint_and_quota_project(self, mock_gcp_bq):
mock_gcp_client = mock_gcp_bq.Client
options = PipelineOptions(['--bigquery_endpoint=https://bq.example.com'])
bigquery_tools.BigQueryWrapper._gcp_bigquery_client(
quota_project_id='billing', pipeline_options=options)
Expand Down
Loading