Repository navigation
Revert errant google-adk bump on master - #40687
Merged
Merged
Conversation
shunping
approved these changes
Oct 20, 2026
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR cleanly reverts an unintended dependency version change to ml_adk_dependency in sdks/python/setup.py that was pushed directly to master in commit cdf9c3ada8.
🔍 General Feedback
- The revert restores the exact pinned versions for
google-adk(==1.28.1) and the OpenTelemetry packages (==1.37.0) from the previous state (62f901f6bf). - Looks good and safe to merge.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40687 +/- ##
=============================================
+ Coverage 56.16% 80.03% +23.86%
=============================================
Files 1124 490 -634
Lines 178336 82818 -95518
Branches 1489 0 -1489
=============================================
- Hits 100170 66281 -33889
+ Misses 75645 16537 -59108
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rogue agent pushed code directly to master :(