Skip to content

Fix Release Nightly Snapshot job #40685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 7 commits into from
Oct 20, 2026
Merged

Fix Release Nightly Snapshot job #40685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
a27d05d
Remove redundant finalize method
Amar3tto Oct 20, 2026
ed667a6
Fix instanceof
Amar3tto Oct 20, 2026
51e0a1f
Suppress warning
Amar3tto Oct 20, 2026
9165340
Suppress warning
Amar3tto Oct 20, 2026
754dc7b
Add exclusion
Amar3tto Oct 20, 2026
802d0e0
Fix typo
Amar3tto Oct 20, 2026
8b7a63c
Remove suppress
Amar3tto Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1641,6 +1641,7 @@ class BeamModulePlugin implements Plugin<Project> {
"StringCaseLocaleUsage",
// DoFn methods are executed reflectively at pipeline runtime
"UnusedMethod",
"PatternMatchingInstanceof"
]
disabledChecks.each {
options.errorprone.errorproneArgs.add("-Xep:${it}:OFF")
Expand Down
6 changes: 0 additions & 6 deletions sdks/java/io/jms/src/main/java/org/apache/beam/sdk/io/jms/JmsIO.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,12 +1001,6 @@ private void closeAutoscaler() {
LOG.error("Error closing autoscaler", e);
}
}

@Override
@SuppressWarnings({"Finalize", "removal"})
protected void finalize() {
doClose();
}

@damccorm damccorm Oct 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abacn could you take a look at this piece?

@Amar3tto could you add context on this piece?

@Amar3tto Amar3tto Oct 20, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The finalize() method is deprecated and marked for removal in newer Java versions. Since UnboundedJmsReader already implements close() to release JMS resources, the finalizer is redundant. Resource cleanup should be handled explicitly through the reader lifecycle rather than relying on GC, which does not guarantee finalizer execution.

}

/**
Expand Down
Loading