Repository navigation
Fix IcebergIO Integration Tests on Dataflow workflows - #40684
Merged
Merged
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
📋 Review Summary
This PR adds the beam.iceberg.lakehouse.warehouse and beam.iceberg.lakehouse.locations system properties to the dataflowIntegrationTest task in sdks/java/io/iceberg/build.gradle, aligning it with integrationTest so that LakehouseCatalogCdcWriteIT and DeltaLakeToIcebergCdcIT have the required catalog configurations when running on Dataflow.
🔍 General Feedback
- The changes are clean, accurate, and directly resolve the missing property configuration for the Dataflow Iceberg integration tests.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
damccorm
approved these changes
Oct 20, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #34962
Successful run:
https://github.com/apache/beam/actions/runs/39408502916