Repository navigation
[Python] Support Protobuf 7.x - #40581
sofiathoren wants to merge 4 commits into
Conversation
There was a problem hiding this comment.
📋 Review Summary
This PR updates the upper bound of the protobuf dependency in sdks/python/setup.py from <7.0.0.dev0 to <8.0.0.dev0 to allow Protobuf 7.x in the Python SDK. The change is clean, follows the precedent set for previous major Protobuf version bumps, and aligns with downstream Google Cloud dependencies.
🔍 General Feedback
- The version constraint update is well-scoped and preserves existing exclusions for known problematic 4.x versions.
- Consider adding a brief note in
CHANGES.mdif you'd like this dependency support expansion highlighted in the next release notes.
💡 Tip: Comment /gemini review on this pull request to trigger a new Gemini code review.
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40581 +/- ##
=============================================
+ Coverage 56.16% 79.93% +23.76%
=============================================
Files 1124 488 -636
Lines 178336 82347 -95989
Branches 1489 0 -1489
=============================================
- Hits 100170 65825 -34345
+ Misses 75645 16522 -59123
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
LGTM, but similar rationale as #35477 (comment), we may want to do this after the coming release cut (10/18).
Also before we merge, let's add an entry to CHANGES.md.
|
@shunping thanks for review. I added an entry in CHANGES.md so please have a look once you get time over :) |
ada3e81 to
ab38200
Compare
My mistake; the branch cut is actually on Oct 28. I will check back after that. |
Why? Currently Apache Beam pins
protobuf<7.0.0.dev0insdks/python/setup.py. Protobuf 7.34.0 was released on February 27, 2026 (https://pypi.org/project/protobuf/7.34.0/, https://github.com/protocolbuffers/protobuf/releases/tag/v34.0), and downstream Google Cloud dependencies (google-api-core,proto-plus,grpcio-status,google-cloud-bigquery) now supportprotobuf<8.0.0.Fixes #40580.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.