Repository navigation
Catch alternate exception type in NumpyBatchConverter - #40553
Conversation
|
Assigning reviewers: R: @shunping for label python. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40553 +/- ##
=============================================
+ Coverage 56.16% 79.74% +23.57%
=============================================
Files 1124 487 -637
Lines 178336 82282 -96054
Branches 1489 0 -1489
=============================================
- Hits 100170 65612 -34558
+ Misses 75645 16670 -58975
+ Partials 2521 0 -2521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
NumPy 2.4.6+ can raise a ValueError instead of a TypeError when handed a dtype it cannot convert, leading to breakages when exercising this code (caught with local runs against the pytorch_type_compatibility_test.py suite.) Catching both and raising as the expected TypeError maintains the expected behavior within Beam.