Repository navigation
[Iceberg CDC source] Allow dropping PK or watermark columns - #40457
Conversation
|
assign set of reviewers |
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Java unit tests failing for irrelevant reason (see #40448). |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #40457 +/- ##
============================================
- Coverage 59.04% 58.75% -0.29%
+ Complexity 15624 13920 -1704
============================================
Files 2797 2584 -213
Lines 280750 271511 -9239
Branches 12488 11243 -1245
============================================
- Hits 165764 159531 -6233
+ Misses 108540 105979 -2561
+ Partials 6446 6001 -445
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Reminder, please take a look at this pr: @Abacn @chamikaramj |
|
R: @chamikaramj |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Allows dropping primary key columns or watermark column in CDC reads. The source still reads them internally to function properly, then drops them in a final step. Configurations that are valid today keep the same graph and coders, so this is update compatible.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.