Skip to content

Fix Iceberg CDC reads with filtering on DATE, TIME, TIMESTAMP - #40455

Merged
ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:cdc-read-temporal-filter
Oct 7, 2026
Merged

ahmedabu98 merged 1 commit into
apache:masterfrom
ahmedabu98:cdc-read-temporal-filter

Conversation

@ahmedabu98

Copy link
Copy Markdown
Contributor

SerializableChangelogTask now binds each task’s residual to the table schema before serializing it, so temporal literals are written as ISO strings that ExpressionParser.fromJson can parse


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.

@github-actions github-actions Bot added java io iceberg Iceberg IO connector labels Oct 7, 2026
@codecov

codecov Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.74%. Comparing base (69bdf5f) to head (9e262c0).
⚠️ Report is 41 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40455      +/-   ##
============================================
- Coverage     59.04%   58.74%   -0.31%     
+ Complexity    15624    13907    -1717     
============================================
  Files          2797     2584     -213     
  Lines        280750   271449    -9301     
  Branches      12488    11229    -1259     
============================================
- Hits         165764   159455    -6309     
+ Misses       108540   105999    -2541     
+ Partials       6446     5995     -451     
Flag Coverage Δ
java 65.24% <ø> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ahmedabu98

Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions

github-actions Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.
R: @chamikaramj for label iceberg.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ahmedabu98

Copy link
Copy Markdown
Contributor Author

Java unit tests failing for irrelevant reason (see #40448). Merging now

@ahmedabu98
ahmedabu98 merged commit 0291da1 into apache:master Oct 7, 2026
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants