Skip to content

[Spark] Run ValidatesRunner tests serially, runner metrics are JVM wide #40428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abacn merged 1 commit into from
Oct 6, 2026
Merged

[Spark] Run ValidatesRunner tests serially, runner metrics are JVM wide #40428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_PVR_Spark3_Streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 9,
"modification": 10,
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner"
}
3 changes: 2 additions & 1 deletion .github/trigger_files/beam_PostCommit_Java_PVR_Spark4_Batch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner"
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner",
"https://github.com/apache/beam/issues/40427": "Spark ValidatesRunner tests run serially"
}
3 changes: 2 additions & 1 deletion .github/trigger_files/beam_PostCommit_Java_PVR_Spark4_Streaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner"
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner",
"https://github.com/apache/beam/issues/40427": "Spark ValidatesRunner tests run serially"
}
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_PVR_Spark4_StructuredStreaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run.",
"modification": 1
"modification": 2
}
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_PVR_Spark_Batch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 7,
"modification": 8,
"https://github.com/apache/beam/pull/39990": "removing dead code from FnApiDoFnRunner"
}
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 4
"modification": 5
}
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_Spark4.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
{
"comment": "Modify this file in a trivial way to cause this test suite to run",
"modification": 2
"modification": 3
}
3 changes: 2 additions & 1 deletion .github/trigger_files/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,5 +9,6 @@
"https://github.com/apache/beam/pull/34155": "noting that PR #34155 should run this test",
"https://github.com/apache/beam/pull/35159": "moving WindowedValue and making an interface",
"https://github.com/apache/beam/pull/39793": "noting that PR #39793 should run this test",
"https://github.com/apache/beam/pull/40103": "noting that PR #40103 should run this test"
"https://github.com/apache/beam/pull/40103": "noting that PR #40103 should run this test",
"https://github.com/apache/beam/issues/40427": "Spark ValidatesRunner tests run serially"
}
5 changes: 5 additions & 0 deletions runners/spark/job-server/spark_job_server.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,11 @@ def sickbayTests = [
'org.apache.beam.sdk.transforms.ReshuffleTest.testReshufflePreservesMetadata',
]

// One pipeline per JVM at a time, Spark runner metrics and the SparkContext are JVM wide.
tasks.withType(Test).configureEach {
systemProperty "beam.validatesRunner.parallelThreads", "1"
}

def portableValidatesRunnerTask(String name, boolean streaming, boolean docker, ArrayList<String> sickbayTests, boolean structuredStreaming = false) {
def pipelineOptions = []
if (structuredStreaming) {
Expand Down
5 changes: 5 additions & 0 deletions runners/spark/spark_runner.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,11 @@ test {
if(project.hasProperty("rerun-tests")) { outputs.upToDateWhen {false} }
}

// One pipeline per JVM at a time, Spark runner metrics and the SparkContext are JVM wide.
tasks.withType(Test).configureEach {
systemProperty "beam.validatesRunner.parallelThreads", "1"
}

class SparkComponents {
List<String> components
}
Expand Down
Loading