Skip to content

Handle null split initialization results in Flink lazy source enumerator - #40417

Merged
chamikaramj merged 1 commit into
apache:masterfrom
ddebowczyk92:fix/flink-lazy-source-null-splits
Oct 23, 2026
Merged

chamikaramj merged 1 commit into
apache:masterfrom
ddebowczyk92:fix/flink-lazy-source-null-splits

Conversation

@ddebowczyk92

Copy link
Copy Markdown
Contributor

Reject unexpected null results during asynchronous split initialization with a descriptive exception instead of an ArrayList.addAll() NPE. Include the source class in initialization errors while preserving the original cause.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README for a list of workflows and how to trigger them.

@github-actions

github-actions Bot commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@ddebowczyk92

Copy link
Copy Markdown
Contributor Author

assign set of reviewers

@github-actions

github-actions Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ddebowczyk92

Copy link
Copy Markdown
Contributor Author

@Abacn Hey, would you mind taking a look?

@ddebowczyk92
ddebowczyk92 force-pushed the fix/flink-lazy-source-null-splits branch from 4fbf693 to 6a69429 Compare October 16, 2026 10:58

@chamikaramj chamikaramj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix.

@chamikaramj
chamikaramj merged commit 6848f84 into apache:master Oct 23, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants