Skip to content

Remove allJavadoc from javaPreCommit - #40367

Merged
reuvenlax merged 1 commit into
apache:masterfrom
reuvenlax:remove_javadoc_from_java_precommit
Oct 1, 2026
Merged

reuvenlax merged 1 commit into
apache:masterfrom
reuvenlax:remove_javadoc_from_java_precommit

Conversation

@reuvenlax

Copy link
Copy Markdown
Contributor

Remove allJavadoc from javaPreCommit. I believe that this is superfluous, as every module should already generate its own Javadoc. In addition there is an aggregate javadoc PostCommit that runs seperately.

Removing this exposed a couple of incorrect dependencies that were being hidden by the allJavadoc rule.

@github-actions

github-actions Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm added as fallback since no labels match configuration

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@reuvenlax
reuvenlax merged commit 7c680c0 into apache:master Oct 1, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants