Repository navigation
Fix partial insertError metric status bug - #40356
Merged
Merged
Conversation
Contributor
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
claudevdm
approved these changes
Sep 30, 2026
| else: | ||
| for insert_error in errors: | ||
| service_call_metric.call(insert_error['errors'][0]) | ||
| # Record the BigQuery reason (e.g. 'invalid') of the first error for |
Collaborator
There was a problem hiding this comment.
Maybe keep the explanation in commit message?
Contributor
Author
There was a problem hiding this comment.
I'll leave the comment content about the behavior (specifically recording the first error) but the extended reasoning is unnecessary, removed
streamline comment
Contributor
Author
|
Test failures are due to known bigtable breakage, merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial insertErrors in BQ inserts were dropping the reason for the error, as it was accidentally passing the entire dict that isn't interpretable otherwise. The end result was a 'None' status that was more opaque.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.