Skip to content

[Python] Fix LogElements crash on global window timestamps #40332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tvalentyn merged 1 commit into from
Oct 5, 2026
Merged

[Python] Fix LogElements crash on global window timestamps #40332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion sdks/python/apache_beam/transforms/util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1978,7 +1978,12 @@ def __init__(
def format_timestamp(self, timestamp):
if self.use_epoch_time:
return timestamp.seconds()
return timestamp.to_rfc3339()
try:
return timestamp.to_rfc3339()
except OverflowError:
# MIN_TIMESTAMP and the global window bounds are outside the datetime
# range.
return str(timestamp)

def process(
self,
Expand Down
8 changes: 8 additions & 0 deletions sdks/python/apache_beam/transforms/util_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2481,6 +2481,14 @@ def test_ptransform_output(self):
| util.LogElements(prefix='prefix_'))
assert_that(result, equal_to(['a', 'b', 'c']))

def test_global_window_with_timestamp_and_window(self):
with TestPipeline() as p:
result = (
p
| beam.Create(['a'])
| util.LogElements(with_timestamp=True, with_window=True))
assert_that(result, equal_to(['a']))

@pytest.fixture(scope="function")
def _capture_logs(request, caplog):
with caplog.at_level(logging.INFO):
Expand Down
Loading