Repository navigation
Fix IcebergIO failing to write EnumerationType (proto enum) fields - #40300
Merged
ahmedabu98 merged 1 commit intoSep 30, 2026
Merged
Conversation
Contributor
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
EnumerationType (used for proto enum fields) wasn't handled in IcebergUtils's Beam-to-Iceberg schema and row conversion. Writing a Row with such a field threw "Unsupported Beam logical type Enum" while deriving the table schema, and threw a ClassCastException converting the row's value even against a pre-existing table. Map EnumerationType to Iceberg's string type on write, the same way Avro and BigQuery already convert it. Fixes apache#40299
mananmangal
force-pushed
the
iceberg-enum-logical-type-40299
branch
from
September 29, 2026 18:21
76d37d7 to
31b8064
Compare
ahmedabu98
approved these changes
Sep 30, 2026
ahmedabu98
left a comment
ahmedabu98
left a comment
Contributor
There was a problem hiding this comment.
LGTM, thanks for adding this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40299
IcebergUtils didn't handle Row fields with the EnumerationType logical type (used for proto enums), so writing one threw
Unsupported Beam logical type Enumduring schema derivation, and a ClassCastException converting the row value even against a pre-existing table.Maps EnumerationType to Iceberg's string type on write, the same way Avro (
AvroUtils) and BigQuery (BigQueryUtils) already convert it.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.