Repository navigation
Fix stale ExecutorClassLoader leak and local JAR staging in portable Spark runner - #40270
Merged
Merged
Conversation
Contributor
Author
|
The race and leak has always been there (#30512 (comment) mitigated in #32723 but never fixed root cause), but only get exposed in Structured Streaming because it uses |
…Spark runner - Set an explicit contextClassLoader on `JobInvoker`, `SparkPipelineRunner`, and `SparkContextFactory` threads so subsequent jobs do not inherit a closed Spark `ExecutorClassLoader` leaked onto shared `grpc-default-executor` threads. - Skip `SparkConf.setJars` in `SparkContextFactory` when running on a local Spark master (`local`, `local[N]`, `local[*]`, `local[N,M]`), avoiding copying classpath JARs into temporary per-context `userFiles` directories that are deleted when the `SparkContext` stops. - Broaden `SparkCommonPipelineOptions.isLocalSparkMaster` to match all local master variants (`local[*]`, `local[N,M]`) and add unit test coverage in `SparkPipelineOptionsTest`.
Abacn
force-pushed
the
fix-spark-staging
branch
from
September 24, 2026 20:43
f27c491 to
1e72559
Compare
Abacn
marked this pull request as ready for review
September 24, 2026 21:10
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Amar3tto
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #40256
Set an explicit contextClassLoader on
JobInvoker,SparkPipelineRunner, andSparkContextFactorythreads so subsequent jobs do not inherit a closed SparkExecutorClassLoaderleaked onto sharedgrpc-default-executorthreads.Skip
SparkConf.setJarsinSparkContextFactorywhen running on a local Spark master (local,local[N],local[*],local[N,M]), avoiding copying classpath JARs into temporary per-contextuserFilesdirectories that are deleted when theSparkContextstops.Broaden
SparkCommonPipelineOptions.isLocalSparkMasterto match all local master variants (local[*],local[N,M]) and add unit test coverage inSparkPipelineOptionsTest.Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.