Skip to content

Revert "fix Bigtable naming for yaml related files" - #40245

Merged
derrickaw merged 1 commit into
masterfrom
revert-40206-20260921_updateBigTableNaming
Sep 23, 2026
Merged

derrickaw merged 1 commit into
masterfrom
revert-40206-20260921_updateBigTableNaming

Conversation

@derrickaw

@derrickaw derrickaw commented Sep 23, 2026 •

Copy link
Copy Markdown
Collaborator
  1. Reverts fix Bigtable naming for yaml related files #40206
  2. Tried running bigtable yaml test with ReadFromBigTable and WriteToBigTable transform types to verify if naming was case insensitive, but its not. So this is a breaking change for customers.
  3. We could add an alias to support both in the naming styles, but seems little benefit.
  4. To eliminate impact to customers and since these changes do not bring much benefit, we should revert the changes back to BigTable instead of Bigtable.
  5. [Task]: Update BigTable to Bigtable to match industry standards #40202

@codecov

codecov Bot commented Sep 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.29%. Comparing base (d1ebefb) to head (2766d56).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #40245      +/-   ##
============================================
- Coverage     57.29%   57.29%   -0.01%     
  Complexity     3696     3696              
============================================
  Files          1201     1201              
  Lines        194397   194397              
  Branches       3889     3889              
============================================
- Hits         111373   111372       -1     
- Misses        79416    79417       +1     
  Partials       3608     3608              
Flag Coverage Δ
python 79.84% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@derrickaw
derrickaw marked this pull request as ready for review September 23, 2026 18:51
@derrickaw
derrickaw requested a review from damccorm September 23, 2026 18:51

@damccorm damccorm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @damccorm for label python.
R: @Abacn for label java.
R: @chamikaramj for label yaml.
R: @mutianf for label bigtable.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw
derrickaw merged commit a40a3e3 into master Sep 23, 2026
115 checks passed
@derrickaw
derrickaw deleted the revert-40206-20260921_updateBigTableNaming branch September 23, 2026 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants