Repository navigation
Prevent CommitTooLargeException in OrderedEventProcessor on duplicate floods - #40242
Merged
Merged
Conversation
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Contributor
|
R: @slilichenko |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
vishalmore90
force-pushed
the
fix-issue-40240
branch
from
September 25, 2026 14:28
562cc74 to
f2bf550
Compare
stankiewicz
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #40240
Context
A high volume of unprocessed or duplicate events entering the OrderedEventProcessor loop could previously trigger a
CommitTooLargeExceptionin Dataflow, because DLQ emissions were unconditionally appended to the bundle without respecting themaxNumberOfResultsToProducepagination cap.Changes
ProcessingState.java.ProcessorDoFn.reachedMaxResultCountForBundleto consider duplicate volume.skipProcessingblock insideProcessorDoFn.processBufferedEventRangeto break gracefully on limits instead of continuing infinitely.testLargeNumberOfDuplicatesPaginatesCorrectly.Checklist