Repository navigation
[Python] Make read and write buffer size configurable in gcsio - #40184
Merged
Merged
Conversation
This also removes the doubly compressed file check, which depended on the metadata that reload() incidentally populated. The limitation is documented on the class and tracked in googleapis/google-cloud-python#18423.
Add --gcs_read_buffer_size_bytes to GoogleCloudOptions. Defaults to DEFAULT_READ_BUFFER_SIZE.
Add --gcs_write_buffer_size_bytes to GoogleCloudOptions. Defaults to DEFAULT_READ_BUFFER_SIZE. Validated as a multiple of 256 KiB, as required by GCS resumable uploads.
Collaborator
Author
|
r: @damccorm |
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--gcs_read_buffer_size_bytesand--gcs_write_buffer_size_bytestoGoogleCloudOptions, which control the buffer size of gcsio read and write,.Parent PR: #40182