Repository navigation
[Iceberg CDC sink] Top API layer - #40161
Merged
Merged
Conversation
…write-cdc-rows
ahmedabu98
marked this pull request as ready for review
September 21, 2026 22:17
Contributor
|
Assigning reviewers: R: @Abacn for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
chamikaramj
reviewed
Sep 22, 2026
| * .withTriggeringFrequency(Duration.standardMinutes(1))); | ||
| * }</pre> | ||
| */ | ||
| public static WriteCdcRows writeCdcRows(IcebergCatalogConfig catalog) { |
Contributor
There was a problem hiding this comment.
Can we expose this through the Managed I/O API and recommend that ? I already exposed Delta Lake CDC read through the Managed I/O API.
Contributor
Author
There was a problem hiding this comment.
Yep will follow up with another PR for the SchemaTransform
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Top-level API exposed as IcebergIO.writeCdcRows.
Validates the configuration and input schema, then wires all the stages together.
Returns an IcebergWriteResult that now also exposes the replayable DLQ and, with error handling on, the failed rows (that will still fail if replayed again).
Also updated the package doc to fully describe the sink's contract.
Part of #39979
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.