Repository navigation
Track ReplaceTokens values as processResources inputs - #40133
Merged
Merged
Conversation
Gradle treats the `tokens:` map passed to the ReplaceTokens content filter as a filter argument, not a task input, so it affects neither the up-to-date check nor the build cache key. The filtered sources contain only unsubstituted placeholders and are byte identical regardless of what the tokens expand to, so nothing invalidates processResources when a token value changes. In a shared checkout where build/ survives branch switches, the task stays UP-TO-DATE and the previous branch's substituted resource is left behind. Switching master -> a former release branch left dataflow.properties holding master's container version, so pipelines ran against a wrong version of beam-master SDK harness. The same staleness also poisons the build cache, since both branches compute the same key for different correct outputs, so `clean` is not a reliable workaround. This can be fixed by declaring the token map as an input property.
Collaborator
Author
|
r: @derrickaw |
shunping
marked this pull request as ready for review
September 15, 2026 16:10
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
stankiewicz
self-requested a review
September 16, 2026 13:29
stankiewicz
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gradle treats the
tokens:map passed to the ReplaceTokens content filter as a filter argument, not a task input, so it affects neither the up-to-date check nor the build cache key. The filtered sources contain only unsubstituted placeholders and are byte identical regardless of what the tokens expand to, so nothing invalidatesprocessResourceswhen a token value changes.In a shared checkout where build branch switches, the task stays UP-TO-DATE and the previous branch's substituted resource is left behind. Particularly, switching master -> a former release branch left
dataflow.propertiesholding master's container version, so pipelines ran against a wrong version of beam-master SDK harness. The same staleness also poisons the build cache, since both branches compute the same key for different correct outputs, socleanis not a reliable workaround.This can be fixed by declaring the token map as an input property.
Reference: https://docs.gradle.org/current/userguide/incremental_build.html#sec:task_inputs_outputs