Repository navigation
[Java] Fix TextIO gzip split test on Windows - #40078
Conversation
Signed-off-by: xujiantop-crypto <265865031+xujiantop-crypto@users.noreply.github.com>
|
Assigning reviewers: R: @chamikaramj for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
Reminder, please take a look at this pr: @chamikaramj |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @Abacn for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Available commands:
|
|
Reminder, please take a look at this pr: @Abacn |
|
Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment R: @chamikaramj for label java. This pull request likely touches a core component ("core" label). Please review with scrutiny. Available commands:
|
|
Reminder, please take a look at this pr: @chamikaramj |
Fixes #20470
testInitialSplitAutoModeGzassumed the generated gzip file would always exceed 2,000 bytes. On Windows, the generated file is 1,970 bytes, so the test failed before exercisingFileBasedSource.split.This derives the requested bundle size from the actual compressed file length. The existing sanity check still proves the input spans more than two requested bundles, while removing the platform-dependent compression-size assumption and allowing the test to run on Windows.
Testing:
TextIOReadTest$BasicIOTest.testInitialSplitAutoModeGzon WindowsTextIOReadTest$BasicIOTeston Windows (12 tests):sdks:java:core:spotlessJavaCheck