Repository navigation
Adds Delta Lake read support to Beam SQL - #39950
Merged
Merged
Conversation
chamikaramj
force-pushed
the
delta_lake_sql_support
branch
from
September 1, 2026 06:59
1f0e32f to
08b6612
Compare
chamikaramj
changed the title
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
chamikaramj
force-pushed
the
delta_lake_sql_support
branch
from
September 2, 2026 18:40
08b6612 to
f25cd37
Compare
Contributor
|
Assigning reviewers: R: @ahmedabu98 for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
ahmedabu98
approved these changes
Sep 4, 2026
ahmedabu98
left a comment
ahmedabu98
left a comment
Contributor
There was a problem hiding this comment.
LGTM, just a few nits
| String.format(error, this.getClass().getName(), "'fieldNames'")); | ||
| } | ||
| return buildIOReader(begin); | ||
| } |
Contributor
There was a problem hiding this comment.
no need to override this method if pushdown isn't supported yet. the super method already does the same thing
Contributor
Author
There was a problem hiding this comment.
I don't think buildIOWriter is implemented in a super class (compilation fails without it).
Comment on lines
+179
to
+185
| @Override | ||
| public ProjectSupport supportsProjects() { | ||
| // TODO: Support project pushdown / column pruning when supported by DeltaIO / | ||
| // Managed Delta | ||
| // Lake source. | ||
| return ProjectSupport.NONE; | ||
| } |
chamikaramj
force-pushed
the
delta_lake_sql_support
branch
from
September 8, 2026 01:10
f25cd37 to
7bbb633
Compare
chamikaramj
commented
Sep 8, 2026
Comment on lines
+179
to
+185
| @Override | ||
| public ProjectSupport supportsProjects() { | ||
| // TODO: Support project pushdown / column pruning when supported by DeltaIO / | ||
| // Managed Delta | ||
| // Lake source. | ||
| return ProjectSupport.NONE; | ||
| } |
| String.format(error, this.getClass().getName(), "'fieldNames'")); | ||
| } | ||
| return buildIOReader(begin); | ||
| } |
Contributor
Author
There was a problem hiding this comment.
I don't think buildIOWriter is implemented in a super class (compilation fails without it).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, updates DeltaIO to correctly parse schema and values for Date and Timestamp types.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.